search

plone / plone.supermodel

Provides XML import and export for schema interfaces based on zope.schema fields
5 stars 8 forks source link

Add missing i18n serialization from schema value to XML model #9

Closed datakurre closed 9 years ago

datakurre commented 9 years ago

Replaces https://github.com/plone/plone.supermodel/pull/8

tisto commented 9 years ago

@jensens I think your pull request merge broke the AT tests:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/2248/#showFailuresLink

Please check and revert if necessary.

datakurre commented 9 years ago

Those errors cannot be caused by this pull (DX supermodel has nothing to do with Archetypes or language tool), but I try to look the issue tonight.

jensens commented 9 years ago

agreed, i dont think this one can cause it

datakurre commented 9 years ago

I think, those errors are caused by Diazo not being turned off during tests. @bloodbare Could you please check, why Diazo is not turned off in Products.PloneLanguageTool language negotiation tests? I could not figure it out, but it seems language is negotiated correctly at first, but then Diazo transformation (for barceloneta theme) is setting language cookie back to the default language ('en').

E.g. http://jenkins.plone.org/job/plone-5.0-python-2.7-at/2359/console

tisto commented 9 years ago

@jensens @datakurre I removed P.PloneLanguageTool from auto-checkouts to fix the build for now. I suspect that this pull request merge from @jensens is responsible:

https://github.com/plone/Products.PloneLanguageTool/pull/4

@jensens @tomgross would you mind having a look?