Update links - Githubissues

plone / plone.testing

Provides tools for writing unit and integration tests in a Zope and Plone environment. It is not tied to Plone, and it does not depend on Zope 2 (although it has some optional Zope 2-only features)

https://pypi.org/project/plone.testing/

3 stars 9 forks source link

Update links #71

Closed jugmac00 closed 4 years ago

jugmac00 commented 4 years ago

the wikipedia link now uses https
the diveintopython link was broken and has been fixed

mister-roboto commented 4 years ago

@jugmac00 thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

jugmac00 commented 4 years ago

@jenkins-plone-org please run jobs

thet commented 4 years ago

Tnx for the PR! I ignore the failing test. It's not related to this PR.

thet commented 4 years ago

Oh, now I did miss something. The news entry's number should 1) reference an issue number, if one exists 2) or reference the PR number. In that case I create a xxxx.bugfix, xxxx.breaking or xxxx.feature file, as defined here: https://github.com/plone/plone.releaser/blob/master/pyproject.toml . Then I create the PR and update the news entry with the PR number.

That should be documented, but isn't. I added an Issue at: https://github.com/plone/documentation/issues/1112

thet commented 4 years ago

Fixed.

jugmac00 commented 4 years ago

Sorry. I am not familiar with towncrier but as there is a check for a news fragment I kinda figured out what to do by looking at an older pull request. But as you noticed, I both messed up the number and the type. No clue where I looked for the number, but the type I got from the official towncrier documentation ( https://pypi.org/project/towncrier/ ). But obviously you do not support all types.

Thanks for cleaning up!