search

plone / plone.volto

Plone add-on to configure Plone with Volto, the new default frontend for Plone 6.
https://6.demo.plone.org/
3 stars 3 forks source link

Fix changed behavior and marker interfaces for plone.leadimage and plone.richtext. #134

Closed thet closed 4 months ago

thet commented 6 months ago

See: https://github.com/plone/plone.app.contenttypes/pull/480

... these are some coincidentally grep/rg findings.

mister-roboto commented 6 months ago

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

sneridagh commented 6 months ago

I just deployed today a version 4 to a Plone 5. Is this breaking for Plone 5?

On Fri, 24 Nov 2023 at 22:41, Érico Andrei @.***> wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/plone/plone.volto/pull/134#pullrequestreview-1748440800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADW4DYC7FAOD2F2HMJGSOLYGEH7JAVCNFSM6AAAAAA7ZN4STWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBYGQ2DAOBQGA . You are receiving this because your review was requested.Message ID: @.***>