plone / plone.z3cform

plone.z3cform is a library that allows use of z3c.form with Zope 2 and the CMF.
GNU General Public License v2.0
0 stars 0 forks source link

use latest z3c.form #20

Closed petschki closed 2 years ago

petschki commented 2 years ago

see https://github.com/plone/Products.CMFPlone/issues/3459

fixes #12

mister-roboto commented 2 years ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 2 years ago

this needs https://github.com/plone/buildout.coredev/pull/782 with the updated versions.cfg

/cc @jensens how is the workflow of merging this?

ale-rt commented 2 years ago

this needs plone/buildout.coredev#782 with the updated versions.cfg

/cc @jensens how is the workflow of merging this?

I would say merge this one and plone.app.z3cform then bump z3c.form = 4.2 in buildout.coredev.

ale-rt commented 2 years ago

Maybe before doing this also the plone.app.dexterity tests need some love

petschki commented 2 years ago

tested here https://github.com/plone/buildout.coredev/pull/782