search

plone / plone.z3cform

plone.z3cform is a library that allows use of z3c.form with Zope 2 and the CMF.
GNU General Public License v2.0
0 stars 0 forks source link

Config with default template #24

Closed gforcada closed 1 year ago

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

This change made Jenkins fail:

File "/home/jenkins/workspace/plone-6.0-python-3.11/src/plone.z3cform/src/plone/z3cform/crud/README.txt", line 503, in README.txt
Failed example:
    print(html) \
    # doctest: +ELLIPSIS +NORMALIZE_WHITESPACE
Expected:
    <form action="http://nohost/context?crud-edit.form.page=1"
              method="post">
    ...
Got:
      <form action="http://nohost/context?crud-edit.form.page=1" method="post" >

(diff edited for brevity and clarity)

I fix it here, with a bit of explanation: https://github.com/plone/plone.z3cform/pull/25