plone / plone.z3cform

plone.z3cform is a library that allows use of z3c.form with Zope 2 and the CMF.
GNU General Public License v2.0
0 stars 0 forks source link

Fix Jenkins tests. #25

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

When running only the plone.z3form tests, the test matched the outcome:

<form action="http://nohost/context?crud-edit.form.page=1" method="post">

The same is true on the Jenkins PR jobs, which are run in parallel threads. But in Jenkins core jobs, the output is this:

<form action="http://nohost/context?crud-edit.form.page=1" method="post" >

So after "post" there is an extra space.

There are a few more changes, probably due to zpretty having been run somewhere:

>                 <span class="header-select" title="">select</span>
---
<                 <span title="" class="header-select" >select</span>

It is strange that the parallel jobs pass, but the core jobs fail. This also means it use useless to run PR jobs for this change.

mister-roboto commented 1 year ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

Cool, thanks!

zpretty diffs are so big, that it makes it difficult to track what's happening there (like on p.a.content PR) 😵‍💫

gforcada commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

I enabled the gh-actions shared workflow for this repo.

I will merge now, because Jenkins is not busy enough. ;-)