search

plone / plone.z3cform

plone.z3cform is a library that allows use of z3c.form with Zope 2 and the CMF.
GNU General Public License v2.0
0 stars 0 forks source link

fix edit/delete for batched crud forms #7

Closed frisi closed 5 years ago

frisi commented 5 years ago

w/o passing the batch-page to the form-handler, it can not know which subforms have been rendred and is always using the first batch - resulting in no items of the other batches being editable or deleteable

mister-roboto commented 5 years ago

@frisi thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

frisi commented 5 years ago

@jenkins-plone-org please run jobs @petschki ohne PR geh' ich heut' nicht heim ;-)

petschki commented 5 years ago

mind writing a test for that? 😜

petschki commented 5 years ago

unfortunately, there are some missing version pins for travis-ci. https://travis-ci.org/plone/plone.z3cform/builds/584125315#L218 ... can u take a look at that?

frisi commented 5 years ago

mind writing a test for that? stuck_out_tongue_winking_eye

:roll_eyes: to be honest: yes. i already spent way too much time on the feature i'm working on while i noticed this issue

the doctest currently used does not use testbrowser but simply fakes the request https://github.com/plone/plone.z3cform/blob/0.9.0/src/plone/z3cform/crud/README.txt#L485

as the test-setup lacks the plone.app.layout global views and also the zope-app-server i faked the context and duplicated the plone_context_state logic into the crud view to not depend on plone.app.layout in the tests.

frisi commented 5 years ago

@jenkins-plone-org please run jobs

frisi commented 5 years ago

@petschki happy now?

happy

frisi commented 5 years ago

@tisto - could you please release a 0.9.2 with this fix? thank you!