search

plone / ploneorg.addonlisting

Add-on listing for Plone.org
https://plone.org
1 stars 1 forks source link

Schema change #11

Closed ghost closed 7 years ago

ghost commented 7 years ago

Added additional fields to the schema to retrieve useful information from PyPI

addresses #6

ghost commented 7 years ago

Which option would be better for downloads- Sum of download count of all release versions or download count of the latest version?

ghost commented 7 years ago

Is it fine to use the upload time of the first version to determine the newest / recently added addons?

loechel commented 7 years ago

Hi @pavithirakc,

the download sum I have added was for total, but it would as you might seen on the post from zopyx, to have two fields, download_sum_total and download_sum_latest

As one version could have multiple uploaded Distribution files, and every of those got count separately, that would make sense.

So it is just a helper field, that store the date that would be shown, as recalculate on every browser view would be expensive.

I am not sure if the list of versions is sorted by adding time or version key. So you might have to look at all versions to look and their upload time to determine the newest.

tkimnguyen commented 7 years ago

@loechel do you want to review the PR and/or approve the merging and then do the merging? If you don't have time let me know and I can proceed.

loechel commented 7 years ago

@tkimnguyen As long as it is flaged WIP I will not review or merge it. As soon as @pavithirakc change the state and request for merge I will review and merge.

tkimnguyen commented 7 years ago

Ah, ok, I was fooled by this: screenshot

loechel commented 7 years ago

@pavithirakc Thanks