search

plone / ploneorg.addonlisting

Add-on listing for Plone.org
https://plone.org
1 stars 1 forks source link

Listing view #19

Closed ghost closed 7 years ago

loechel commented 7 years ago

@pavithirakc I have pushed you some help into this branch / pull request.

please label "needs: review" when we should start reviewing, as you still work on this branch, guessing from the time stamps of your commits

jensens commented 7 years ago

Please use labels instead of a [WIP] prefix in the title. This helps maintainers to filter issues and PRs.

loechel commented 7 years ago

@pavithirakc I just pushed you a simplified folder view as help that shows you how you could directly include the view of an addon as the modal.

Have a look and may build on top of that.

fireshot capture 67 - add-ons webs_ - http___www localhost com_8080_plone3_add-ons_simplified_view fireshot capture 68 - add-ons webs_ - http___www localhost com_8080_plone3_add-ons_simplified_view

loechel commented 7 years ago

@pavithirakc I have prepared you some help to have an included form and filter functions. take a look at it, if that helps you on going forward.

loechel commented 7 years ago

@pavithirakc could we close this pull request / merge it, and do following modifications in a new Pull request. Otherwise it become to complex or hard to review.

ghost commented 7 years ago

@loechel. Sure, I'll push commits cli-scripting into a new branch then.

ghost commented 7 years ago

I am not able to figure out why changing widgets in contents.py is causing error on bin/instance fg. So, I have commented out the line in the last commit. I tried to follow https://docs.plone.org/develop/plone/forms/z3c.form.html#setting-widget-for-z3c-form-plain-forms.

loechel commented 7 years ago

OK, Final round on this pull request, as you @pavithirakc have seen I have pushed a fix for the widgets for the filter form. Is that how you would like that? If so change the label to ready and I will merge.

We then should go to cli scripts and also revisit the browser view once more, but maybe talk before.

ghost commented 7 years ago

Thanks @loechel, that is what I wanted (checkbox as a widget). And I wanted dropdown for choice fields because of variable length of the options. Hence, added a commit. Also Like you said, I'll revisit the views later.