search

plone / ploneorg.addonlisting

Add-on listing for Plone.org
https://plone.org
1 stars 1 forks source link

missing requirements in setup.py? #2

Closed tkimnguyen closed 7 years ago

tkimnguyen commented 7 years ago

According to https://community.plone.org/t/bin-instance-fg-gives-error-importerror-no-module-named-requests/ are simplejson and requests missing from setup.py?

loechel commented 7 years ago

yes they are missing, they are part of ploneorg.core setup.py so they have never been missing in any development before, as we build on top of ploneorg.core

@pavithirakc might resolve this by adding to install_requires in setup.py and make a pull request to learn the procedures.

loechel commented 7 years ago

Fixed with 39b60dbd43e50a7583bba6f088a098352ebdda6f