search

plone / plonetheme.barceloneta

The default theme for Plone Classic UI
https://pypi.python.org/pypi/plonetheme.barceloneta
19 stars 41 forks source link

Fix Diazo rule problem with undefined footer_portlets and footer_port… #322

Closed thet closed 1 year ago

thet commented 1 year ago

…lets_count variables.

See: https://community.plone.org/t/error-theme-inherited-from-barceloneta-footer-portlets-count/8455

Cherry-pick for Plone 6.0 of: https://github.com/plone/plonetheme.barceloneta/pull/239

mister-roboto commented 1 year ago

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

thet commented 1 year ago

@jenkins-plone-org please run jobs