Use portal_url to root all CSS and rules file links

[jensens]

1. What is the problem solved here?
2. Does this work together with collective.lineage and/or lineage.themeselection? The relative .. at least was very pleasant in such environments.
3. Do we want this change in an old maintenance branch

[erral]

Sorry, I had no time to elaborate on this.

Hau idatzi du Maik Derstappen @.***) erabiltzaileak (2023 aza. 21(a), ar. (15:09)):

@.**** commented on this pull request.

On plonetheme/barceloneta/theme/manifest.cfg https://github.com/plone/plonetheme.barceloneta/pull/341#discussion_r1400659890 :

what about tinymce-content-css = /++theme++barceloneta/css/barceloneta.min.css?

this would break in several situations ;).

— Reply to this email directly, view it on GitHub https://github.com/plone/plonetheme.barceloneta/pull/341#discussion_r1400659890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGHRVOLX6RH45LBHM3XCFTYFSY3BAVCNFSM6AAAAAA2PQIVACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBSGEYTQOBQGY . You are receiving this because you authored the thread.Message ID: @.***>

-- Mikel Larreategi @.***

CodeSyntax Azitain industrialdea, 3-K - Eibar Tfnoa.: +34 943821780

[yurj]

1. What is the problem solved here?

• different url for the same css file, cache problems
• traversing private content can lead to "Insufficient privileges" while the resource itself is public

2. Does this work together with collective.lineage and/or lineage.themeselection? The relative .. at least was very pleasant in such environments.

This should be solved in that packages, eventually. But we can avoid it implementing it just in the backend and let people use it in their own custom theme. backend.xml is part of this package but has the problems above (different url and traversing private content).

3. Do we want this change in an old maintenance branch

I've created this PR on current master: https://github.com/plone/plonetheme.barceloneta/pull/376

[mtrebron]

I woud feel more comfortable if plain TAL would be used in the manifest and making this the canonical way. See other usage here: https://github.com/search?q=org%3Aplone+portal_state%2Fportal_url&type=code

[jensens]

I woud feel more comfortable if plain TAL would be used in the manifest and making this the canonical way. See other usage here: https://github.com/search?q=org%3Aplone+portal_state%2Fportal_url&type=code

Why? The usage here is IMO totally fine. And it is fast too.

[mtrebron]

(edited) @jensens -https://github.com/plone/plonetheme.barceloneta/pull/376 addresses this issue for manifest.cfg and was merged, I suggest we close this one. I have no opinion on the other parts of this PR.