plone / plonetheme.barceloneta

The default theme for Plone Classic UI
https://pypi.python.org/pypi/plonetheme.barceloneta
19 stars 41 forks source link

issue_96 #348

Closed Ananyasingh2002 closed 7 months ago

Ananyasingh2002 commented 1 year ago

I changed the stylesheet path from an absolute one (starting with "/") to a relative path (starting with "./"). This adjustment ensures that when the website is hosted in a subfolder, like http://somesite.com/plonesite/, the stylesheet is correctly located and loaded relative to the subfolder. The original absolute path caused the browser to look for the stylesheet at the root of the entire website, leading to loading errors when the site was in a subfolder. The relative path directs the browser to the correct location, resolving the problem and ensuring the stylesheet is applied as intended within the subfolder context.

mister-roboto commented 1 year ago

@Ananyasingh2002 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

mister-roboto commented 1 year ago

@Ananyasingh2002 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

MrTango commented 7 months ago

I'm closing this, for one because this is making problems on other ends and needs more testing and on the other side, the code contributor agreement is still missing.