search

plone / plonetheme.barceloneta

The default theme for Plone Classic UI
https://pypi.python.org/pypi/plonetheme.barceloneta
19 stars 41 forks source link

Sanitize color variable definition #351

Closed petschki closed 10 months ago

petschki commented 11 months ago

Right now you have to customize $plone-link-color variable to change Bootstrap's $primary color. This changes to a more Bootstrap like approach to define $primary as Plone blue and the link color derives from it. Since everything has the same values, no new compiled css code is generated.

mister-roboto commented 11 months ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 11 months ago

@jenkins-plone-org please run jobs