search

plone / training

Plone Trainings
https://training.plone.org
Creative Commons Attribution 4.0 International
57 stars 89 forks source link

Issue on page /voltohandson/footer.html #681

Open flipmcf opened 1 year ago

flipmcf commented 1 year ago

Should we be throwing css into custom.overrides? Would it be better practice to create a .less file inside our Footer directory and import it into footer.jsx

It might lead to bad habits... but maybe there was a good reason to use the overrides.

tiberiuichim commented 1 year ago

I think it's fine to have CSS in custom.overrides. There are a few (minor) differences in how the (generated) CSS loaded from components gets bundled into the CSS bundles, but the main one is that the css from .overrides will be closer to the "original" intended destination, the main CSS theme.

Having said that, I wouldn't worry too much about this issue. Just pick one style and be consistent with it.