search

plone / volto-addon-ci

1 stars 2 forks source link

Question about additional deps #2

Closed sneridagh closed 1 year ago

sneridagh commented 3 years ago

@avoinea Why jest-transform-stub is required again? https://github.com/plone/volto-addon-ci/blob/0d4e8c752619b8b1cb235368679decac0f0fa5cb/docker-entrypoint.sh#L75

also, if you were to add jest-unitsomewhere you would do it in Volto core or in the add ons?

avoinea commented 2 years ago

@sneridagh Don't remember, I think @valentinab25 added. Within the package description it says:

Jest doesn't handle non JavaScript assets by default.
You can use this module to avoid errors when importing non JavaScript assets.
valentinab25 commented 2 years ago

I think we can remove it, we are not using it anymore, looks like we are now using jest-css-modules for the same purpose

sneridagh commented 2 years ago

@avoinea I think so, Volto should provide them, and if not, we should. Anyways I think we are good if we remove them.

wesleybl commented 1 year ago

@sneridagh these dependencies were removed in alpha branch, but not in others. Is this enough to close this issue?

sneridagh commented 1 year ago

I'd say so! btw, I'm now using @plone/scripts addon command for testing Volto add-ons.

https://training.plone.org/effective-volto/testing/addons.html?highlight=plone%20scripts#plone-scripts https://github.com/plone/volto/blob/master/packages/scripts/README.md#addon

wesleybl commented 1 year ago

@sneridagh Interesting! It does not use symlinks, which avoids problems in test execution, since jest does not follow symlinks.