Replace react-dnd with react-beautiful-dnd

plone / volto

React-based frontend for the Plone Content Management System

https://demo.plone.org/

MIT License

486 stars 660 forks source link

Replace react-dnd with react-beautiful-dnd #1900

Open tiberiuichim opened 4 years ago

tiberiuichim commented 4 years ago

react-dnd is used in Contents views. I don't think we need 2 libraries that can do the same thing. I've tested and it's possible (of course) to do table row sorting with react-beautiful-dnd.

tisto commented 4 years ago

I was under the assumption that we already ripped out react-dnd TBH. Definitely +1. cc @iFlameing

tiberiuichim commented 4 years ago

@iFlameing you can use this component: https://github.com/eea/volto-blocks-form/blob/master/src/components/manage/Blocks/DragDropList/DragDropList.jsx and how it can be used to create a sortable "table" https://github.com/eea/volto-taxonomy/blob/2420d96b538634d3b02bd6f56e2a99cc9ba7be17/src/ControlPanel/TaxonomyData.jsx#L79

iFlameing commented 4 years ago

@tisto we removed the react-dnd from Edit view but the folder-content view still uses react-dnd. Once we refactored the folder content view then we are able to remove the react-dnd.

ichim-david commented 5 months ago

Still valid to this day :(