search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
488 stars 664 forks source link

Use <Icon className=.. instead of Icon name=... #3217

Open avoinea opened 2 years ago

avoinea commented 2 years ago

See https://github.com/Semantic-Org/Semantic-UI-React/issues/2322#issuecomment-344576296

Otherwise the console will be full of warnings like:

Warning: Invalid name "xxx-yyy-zzz" used for. Did you mean...
priyansh71 commented 2 years ago

Can this issue be clarified further? All the Icons which utilise a custom .svg have been used from the Icon component of the @plone/volto/components package. Icons used from the semantic-ui-react are all hard-coded icons listed here.