search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
427 stars 575 forks source link

Fix condition for view translation, for missing view case #5351 #5352

Open reebalazs opened 6 months ago

reebalazs commented 6 months ago

Fixes clicking on three dots, which causes an error in case of layout is missing,

It's unclear what causes the layout to be missing. However from the asyncconnect code it's obvious that this is a case to be prepared for, therefore we must be tolerant in the case the layout to be unset, instead of letting the translations engine fail - which caused this error.

reebalazs commented 6 months ago

Remark: I've checked manually that if there is <=1 views, the selector does not show, iow the current behaviour is preserved together with the fix, too.

netlify[bot] commented 6 months ago

Deploy Preview for volto canceled.

Name Link
Latest commit 38793e2cb055d80ddef5193c5ad562702cca9354
Latest deploy log https://app.netlify.com/sites/volto/deploys/6540e1371249e500086486d1
netlify[bot] commented 6 months ago

Deploy Preview for volto canceled.

Name Link
Latest commit 75568c71e0c658d781050ab36773acb9428e665d
Latest deploy log https://app.netlify.com/sites/volto/deploys/6557389c561f520008f1c0bf
sneridagh commented 6 months ago

@reebalazs unit tests fail