plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
479 stars 648 forks source link

YouTube video embed results to error if video url contains /live/ #5416

Closed rioksane closed 11 months ago

rioksane commented 11 months ago

YouTube video embed results to error if video url contains /live/

Sorry, something went wrong with your request
t.url.match(...) is null

Tested at https://demo.plone.org

To Reproduce Steps to reproduce the behavior:

  1. Go to https://www.youtube.com/watch?v=ISdHvS6Ck3k&list=PLGN9BI-OAQkSXMXVBXLWQAQr0AF2xM_NU&index=19
  2. Click on Share
  3. Copy link https://www.youtube.com/live/ISdHvS6Ck3k?si=COeVakmC1lI6jQy3
  4. Go to Plone 6 Volto site add a new page and add video embed block.
  5. Paste url and save page.

Expected behavior Video embed should work

Screenshots

Screenshot 2023-11-20 at 19 15 00 Screenshot 2023-11-20 at 19 17 50

Software (please complete the following information):

rioksane commented 11 months ago

@ericof this is the video embed issue mentioned

pranayjoshi commented 11 months ago

Where is the Video embed option? I can only see the option to add page links etc.

IshaanDasgupta commented 11 months ago

I am working on this

kuv2707 commented 11 months ago

Is the issue resolved?

stevepiercy commented 11 months ago

@kuv2707 yes it is resolved. @IshaanDasgupta resolved it in the linked PR #5426, but because they did not use the magic GitHub keywords in their description, it was not automatically closed. "Solved" is not a keyword.

IshaanDasgupta commented 11 months ago

Sorry didn't know that. Will do that for future PRs

stevepiercy commented 11 months ago

@IshaanDasgupta no worries. We're all learning how to improve and use GitHub features here.