plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
460 stars 624 forks source link

Teaser Grid Block: clicking on close icon "x" should reset the subblock, not go back to the blocks chooser #5478

Open tisto opened 11 months ago

tisto commented 11 months ago

Describe the bug

When I click on the close icon "x" of a teaser or image block in a grid, the subblock is completely removed.

To Reproduce

Steps to reproduce the behavior:

  1. As admin
  2. Create a page with a grid block and a teaser/image
  3. Click on the close "x" button on the teaser/image block
  4. current behavior: the block is removed

Expected behavior

For a client project we amended the functionality to just reset the block (image block without an image, teaser block without a teaser) instead of going back to the block chooser.

At first we were reluctant on that change. Though, working with it for a few weeks revealed that this makes so much more sense than our current Volto core solution.

Screenshots

Screenshot 2023-12-02 at 07 48 10

Software (please complete the following information):

Latest Volto / Plone.

Additional context

I'd consider this to be a UX bugfix. However, this is up to the release manager or Volto team to decide.

tisto commented 11 months ago

@sneridagh I just ran into this and I was shocked when I realized we never pushed this upstream. At first I was reluctant on this change in our client project. Though, now that I ran into the "old" behavior of Volto core I see that this change makes so much sense UX-wise. What do you think?

sneridagh commented 11 months ago

It does, it's in the first iteration stage, take a look:

image

top, right, the reset is in there.

It did not "evolved" as in DLR. I think that @albertcasado also weigh in on this one, and had to do something with it. I can't remember the whole thought path that this followed through the years.

tisto commented 11 months ago

@sneridagh I know that there is a trash icon in the sidebar. It is just very counterintuitive in comparison to the "close icon" approach. The current solution requires two mouse clicks instead of just one. The functionality is hidden when you actually need it (when looking at the block as a whole, you don't see the trash icon, you have to click inside the particular block to see the trash icon and delete it, this is a UX anti-pattern IMHO).

We can discuss this with Albert and get his opinion/approval.

sneridagh commented 11 months ago

I don’t get where is the additional click…

On Sat, 2 Dec 2023 at 08:38, Timo Stollenwerk @.***> wrote:

@sneridagh https://github.com/sneridagh I know that there is a trash icon in the sidebar. It is just very counterintuitive in comparison to the "close icon" approach. The current solution requires two mouse clicks instead of just one. The functionality is hidden when you actually need it (when looking at the block as a whole, you don't see the trash icon, you have to click inside the particular block to see the trash icon and delete it, this is a UX anti-pattern IMHO).

We can discuss this with Albert and get his opinion/approval.

— Reply to this email directly, view it on GitHub https://github.com/plone/volto/issues/5478#issuecomment-1837075727, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADW4DYSWLC5VBH7PN7A3PDYHLLGPAVCNFSM6AAAAABADZUNJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGA3TKNZSG4 . You are receiving this because you were mentioned.Message ID: @.***>

tisto commented 11 months ago

@sneridagh:

instead, you have to:

Two mouse clicks instead of one. Hiding the functionality from the user in the 90% use case (that you don't have the subblock selected that you want to delete).

sneridagh commented 11 months ago

Ok, got it.

Indeed, the evolution that this had in both light theme and in the client project didn't get into core. The core version was mainly developed in sprints, mainly in Innsbruck beginning of this year. Then the others evolved as the core one stayed with the original implementation.

sneridagh commented 11 months ago

Uh, I just realised that the light theme has the core version.

tisto commented 11 months ago

@sneridagh ok, we need to make a decision where to go then.

I started to work with the Volto Light Theme daily for our new website. I am ok with reporting every single issue I find. However, it is important for me that we find a way to either push those things upstream or find another way that we don't have to apply those small improvements over and over again.

I am ok to put this into the Light Theme, if that's the right place in your opinion. I am just the product owner guy here :)

kanhaiya04 commented 10 months ago

@tisto, I comprehend the modifications you've outlined regarding the 'x' icon. If your decision is to alter the functionality of the 'x' icon, I am eager to undertake this task.

stevepiercy commented 10 months ago

@kanhaiya04 this issue needs further direction from @plone/volto-team before any work is performed. It's not clear what @sneridagh @tisto and the rest of the team decided to do for this issue.

sneridagh commented 9 months ago

@tisto did we decided to hold up on this one, until we have a better UX for this, right? Since we realised that the implemented version is the most "correct" one for now. I'd close this one until we don't have anything better.