Closed ujjwaleee26 closed 9 months ago
How would this block be different from either of the following?
@stevepiercy Teaser block
Hero Block
But Announcement Block
I would suggest that you create an add-on for this block, then publish it to the collective GitHub organization or your personal account to share and demonstrate how this would work. The documentation has guidance for developing a block and an add-on.
Some tested and proven add-ons get adopted into Volto core.
@stevepiercy okay,
I would like to say that when I did the volto training , there was no issue in raising a PR , but now , I have actually made the Announcement Block , and I wanted to raise a PR , its says File ignored because of a matching ignore pattern
Sorry, I have no clue what you are talking about or how to reproduce the issue you describe.
pnpm eslint --max-warnings=0 --fix: ESLint found too many warnings (maximum: 0). /Users/ujjwalsinha/volto/packages/volto/src/components/index.js 0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
. Its showing this
Maybe this will help? https://6.docs.plone.org/volto/contributing/linting.html
Maybe this will help? https://6.docs.plone.org/volto/contributing/linting.html
Still no progress , been trying for an entire day , created projects again $ again ,deleting the previous ones and yet no success
@ujjwaleee26 see a follow up to your community forum post, and possibly this PR which I think fixes the issue you described. @sneridagh can you verify?
First of all. This block does NOT belong to the core. If you want to contribute with it, please do it as an add-on.
Second, did you try latest Volto core? I fixed it this week. We are still in an interim fixing things related with the monorepo change. This has to be with the unified ESlint config and lint-staged
. If you need to disable it, make the commit with --no-verify
.
@sneridagh I have made commits using
--no-verify
only . So if commit it again with as an add-on, can I please get a review regarding my PR?
@ujjwaleee26 The above comment means the addon will not belong to this repo. If you really think this block would be beneficial for the community you can publish it somewhere and ask for review in the community forum. If that addon proves to be super useful, it can be considered for publishing under @plone-collective. Note that "not all" addons can be published under collective.
@nileshgulia1 I don't have much Idea about publishing it somewhere . I am very new to this Volto
. I just know how to develop basic things. Is there a process or something?
@nileshgulia1 I don't have much Idea about publishing it somewhere . I am very new to this
Volto
. I just know how to develop basic things. Is there a process or something?
You can publish it under npm with your name. https://docs.npmjs.com/creating-and-publishing-unscoped-public-packages
@nileshgulia1 thanks, I will publish it , but does that mean I have close this PR, or I can leave it here , just for @maintainers to review, if they could, cause as first time contributor,I tried my best?
@ujjwaleee26 that would be putting the cart before the horse. Please do publish it as an add-on, and seek support and feedback from the Community Forum. This issue tracker is focused on Volto core only. Closing.
pnpm eslint --max-warnings=0 --fix: ESLint found too many warnings (maximum: 0). /Users/ujjwalsinha/volto/packages/volto/src/components/index.js 0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
@sneridagh I had this same problem when trying to make a commit. Your tip worked:
If you need to disable it, make the commit with --no-verify
Is this still an issue you are checking into?
An Announcement Block There are many a times when new
Volto
/' Plone` are released . To just display as an announcement message on main website. Integration of new Announcement Block. It can contain a link to redirect to page where detailed description can be foundfor example ,like this,