search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
427 stars 575 forks source link

Add ImageWidget with upload/drop/external and inline/widget capabilities #5607

Open dobri1408 opened 3 months ago

netlify[bot] commented 3 months ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 3c44490a731b4e64963b331cd8794babefcd13bd
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6628a245a646490008fb49c1
netlify[bot] commented 3 months ago

Deploy Preview for volto failed.

Name Link
Latest commit 3c44490a731b4e64963b331cd8794babefcd13bd
Latest deploy log https://app.netlify.com/sites/volto/deploys/6628a245b1491900090e2c6c
dobri1408 commented 3 months ago

I have moved the https://github.com/plone/volto/pull/4142 here, because of the conflicts and the big changes since that pr.

dobri1408 commented 3 months ago

I have considered that is better to return always the URL of the image because it will be easier for developers to use if it is consistent. What do you think @sneridagh?

stevepiercy commented 2 months ago

I compared against production docs.

These look the same. Are they supposed to be the same? I'm not sure what I should expect or look for.

The controls appear broken in the Netlify build:

against production:

Is the difference expected?

Both have a broken image. Should that be fixed?

Please let me know. Thank you!

dobri1408 commented 2 months ago

Hi @stevepiercy, @sneridagh added this for the storybook: https://65c09ac45778640008535e9c--volto.netlify.app/storybook/?path=/story/edit-widgets-image--default, in the old pr, that I have moved here. You can see that shows the Image Widget.

stevepiercy commented 2 months ago

@dobri1408 nice! Let's get a core contributor to review code.

sneridagh commented 1 month ago

@dobri1408 let's try to push this forward. I just merged, we need to fix the tests. I would also be great that we could address what @tiberiuichim was proposing here as well https://github.com/plone/volto/issues/4286 (the link widget is too much, should happen in another phase, addressed by the other PLIP)

dobri1408 commented 2 weeks ago

Hello @sneridagh and @davisagli, I've been working on the Image Widget and think it's a good time for a review to ensure it meets the desired requirements and is ready for merging. I've used the same widget for the image block as well.