For a multilingual website with an inner folder set as navigation root, the logic for the Contents breadcrumb is incorect

plone / volto

React-based frontend for the Plone Content Management System

https://demo.plone.org/

MIT License

453 stars 614 forks source link

For a multilingual website with an inner folder set as navigation root, the logic for the Contents breadcrumb is incorect #5699

Open tiberiuichim opened 8 months ago

tiberiuichim commented 8 months ago

If I have the following content tree structure:

/en/navroot/something

the whole logic in this component collapses, because the store breadcrumbs.items would be just a single item, rooted in the navigation root.

https://github.com/plone/volto/blob/f92880ee4e4c3b88c7cea18c717dd30ecb1e61fa/packages/volto/src/components/manage/Contents/ContentsBreadcrumbs.jsx#L61

ichim-david commented 8 months ago

@gawandeabhishek if the author of the bug report needs to explain the bug and how to fix it, it means that you are not ready to fix this issue. If you are curious about learning about the framework, there is documentation available, training videos on Youtube and of course the source course at your disposal for studying.

There is very little to gain in trying to fix bugs for a product that you haven't worked with and you don't know. If you want to learn something there are tutorials that you can follow and toy projects that you can build but this is a real product with real bugs that need to be fixed by real people who know how to fix them without asking others how would they go about fixing them.

tiberiuichim commented 8 months ago

In my case, I fixed it by:

making a physical-breadcrumbs endpoint, https://github.com/eea/eea.climateadapt.plone/commit/ae977c947a1aa2a02e68f84b890b652d1272d073
customize the ContentsBreadcrumb: https://github.com/eea/volto-cca-policy/commit/a0592aa17b24eb51c8ee146d337094a6cfd37646

stevepiercy commented 8 months ago

Test of locking a conversation, and limiting conversation only to people with write access.

erral commented 8 months ago

Wouldn't be this fixed if we use the @navroot information to build the breadcrumbs?

tiberiuichim commented 8 months ago

@erral no, as far as I could see the navroot gives you the content of the ancestor INavigationRoot item (correct me if I'm wrong). The @breadcrumbs endpoint already has a root field with the path of the navigation root.

I've discussed this with @sneridagh and they had a customized ContentsBreadcrumbs that uses subsite information, probably to fix this exact problem.