search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
428 stars 573 forks source link

Update pnpm-lock.yaml #5852

Closed wesleybl closed 2 months ago

wesleybl commented 2 months ago

When I ran pnpm install the file was updated

netlify[bot] commented 2 months ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit e26b14e1701db6654f9dadffab4fac46cb0c2b44
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65e8b88490b35c0008979fac
netlify[bot] commented 2 months ago

Deploy Preview for volto canceled.

Name Link
Latest commit e26b14e1701db6654f9dadffab4fac46cb0c2b44
Latest deploy log https://app.netlify.com/sites/volto/deploys/65e8b884f04dbf000817b4d0
davisagli commented 2 months ago

@sneridagh Hmm, how did this happen?

sneridagh commented 2 months ago

@wesleybl I just run it in main and for me it did not change. However, @stevepiercy also noted that behavior sometimes. I changed recently the yarnhook for a custom script that does something more appropiate on git checkouts, than it used to be, so now it should be better.

I just run pnpm install in main, and it did not changed anything for me. Make sure you are using the corepack pnpm version (this one uses the pnpm version specified in the package.json file). Remove any other pnpm installation from your machine. Don't know if that is the cause of it but it's quite strange.

sneridagh commented 2 months ago

@davisagli did it change for you if you run it now?

sneridagh commented 2 months ago

I read that pnpm install does more things than yarn install used to do (mainly changing internal metadata, not the versions themselves). I also saw that for something as the hook on git change is better:

pnpm install --prefer-offline --frozen-lockfile --no-verify-store-integrity

See: https://github.com/pnpm/pnpm/issues/6229#issuecomment-1475290177

wesleybl commented 2 months ago

I was on pnpm 8.15.1 and upgraded to 8.15.4. So the file was not updated. Sorry for the noise.