search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
426 stars 575 forks source link

Added download link to filename in file widget #5880

Closed sabrina-bongiovanni closed 1 month ago

sabrina-bongiovanni commented 1 month ago

Added a UniversalLink tag around the filename to allow users to download the file directly from the widget in other views. It's useful if a user needs to download the file but didn't create the content and does not have the original file.

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit f2ba3bd7d738c914b8b343d8daa329db81ef5279
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65f435725618b2000832ef03
netlify[bot] commented 1 month ago

Deploy Preview for volto canceled.

Name Link
Latest commit f2ba3bd7d738c914b8b343d8daa329db81ef5279
Latest deploy log https://app.netlify.com/sites/volto/deploys/65f4357288384d0008908cbb
ichim-david commented 1 month ago

@sabrina-bongiovanni you are missing 2 steps that would make this pull request green:

  1. A change log entry within package/volto/news
  2. pnpm test and updating the test snapshot

If you run into any problems get in touch with your colleagues from Redturtle, they are more than able to help :)

stevepiercy commented 1 month ago
  • A change log entry within package/volto/news

See Change log entry

  • pnpm test and updating the test snapshot

Testing. Oh, wait, that's not much help. @ichim-david could you work on this issue today? 😁

ichim-david commented 1 month ago
  • A change log entry within package/volto/news

See Change log entry

  • pnpm test and updating the test snapshot

Testing. Oh, wait, that's not much help. @ichim-david could you work on this issue today? 😁

@stevepiercy plone tune up day, might be a good time todo something about it indeed :)

sabrina-bongiovanni commented 1 month ago

@sabrina-bongiovanni you are missing 2 steps that would make this pull request green:

  1. A change log entry within package/volto/news
  2. pnpm test and updating the test snapshot

If you run into any problems get in touch with your colleagues from Redturtle, they are more than able to help :)

Thank you so much. I gave a look at these two topics with Piero and I managed to fix the problems. Let's see if the checks go through correctly this time :)

pnicolli commented 1 month ago

To further clarify why the expedite PR instead of a discussion on the new feature: it's a feature the Classic UI file widget had in previous plone versions, this just makes it available again.