search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
426 stars 574 forks source link

Update volto-slate configuration to indicate it is now part of the core. #5884

Closed MostafaMagdyy closed 1 month ago

MostafaMagdyy commented 1 month ago

Update configuration docs: Include volto-slate as part of core and add admonitions about draftJS.

mister-roboto commented 1 month ago

MostafaManga your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit a5cad524de63e96f8d7132d51987905f8d4e1425
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65f62a8084524800083bdac7
netlify[bot] commented 1 month ago

Deploy Preview for volto canceled.

Name Link
Latest commit a5cad524de63e96f8d7132d51987905f8d4e1425
Latest deploy log https://app.netlify.com/sites/volto/deploys/65f62a804899810008ed5122
mister-roboto commented 1 month ago

MostafaManga your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

stevepiercy commented 1 month ago

@MostafaMagdyy would you please check your GitHub emails against that which you used in the Plone Contributor Agreement? There is a mismatch. Either the Plone Foundation made a mistake, or you need to add that email to your GitHub account. Please post a comment here to let us know.

stevepiercy commented 1 month ago

@MostafaMagdyy you have two pull requests open for the same issue (#5886). Neither will be reviewed until you close one. See Item 3 under Things not to do.

See also Item 2, second bullet point, under Create a pull request from your fork.