search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
426 stars 574 forks source link

Notify in documentation useLinkedHeadings setting change after changes from #5225 #5885

Closed ichim-david closed 1 month ago

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit af2c0c154e9369127f9476c3a363bf8d7a7b617f
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65f732a28e808e0008535a87
netlify[bot] commented 1 month ago

Deploy Preview for volto canceled.

Name Link
Latest commit af2c0c154e9369127f9476c3a363bf8d7a7b617f
Latest deploy log https://app.netlify.com/sites/volto/deploys/65f732a242d8900008fd81b4
ichim-david commented 1 month ago

@davisagli I know that we had these changes https://github.com/plone/volto/pull/5225 due to https://github.com/plone/volto/issues/5174 but it rubs me the wrong way that we make an assumption about this feature being useful only for logged-in users. If you want to enable for everyone you need to customize the render file just to remove the token condition.

What do you think about another option skipLinkedHeadlinesForAnon set to true by default?