search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
426 stars 575 forks source link

Toast not working after the upgrade of react-toastify to version v5.5.0 #5895

Open dobri1408 opened 1 month ago

dobri1408 commented 1 month ago

Describe the bug The toast is not showing.

To Reproduce The problem can be replicable if you customize a file with the toast.succes(), or toast.error() function in it. The toast from that file that you customized will not be working, even if you put the same file in customization. This issue is not happening if you put it back to version v5.4.1 which was before this commit https://github.com/plone/volto/pull/5835/files

Expected behavior It should work even if you customize such a file

Software (please complete the following information):

Additional context

dobri1408 commented 1 month ago

@robgietema

davisagli commented 4 weeks ago

@dobri1408 I tried to reproduce this, but toasts are working fine in a customized file in a project we have on Volto 16.31.4.

It might help if you share which file you customized and what is in the customized file. Also, are there any errors in the console?

ichim-david commented 4 weeks ago

@davisagli I might of reopened the issue too soon, I've added the needs: confirmation label for the reason that we need to confirm it's an actual bug. I didn't appreciate that the bug report was closed without any comment for why it seemed "completed". Since he is my colleague I will work together with him to get the reproducible test case, I have a feeling it might happen from other add-ons we have at EEA and not directly an issue of Volto core.