search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
426 stars 575 forks source link

Add id attributes to discussions container and individual comments #5905

Closed ericof closed 1 month ago

ericof commented 1 month ago

Fixes #5904

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit c56efc691f2e09e00a89f7e98908534985ab1711
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65fdd48458f5740008607b8f
netlify[bot] commented 1 month ago

Deploy Preview for volto canceled.

Name Link
Latest commit c56efc691f2e09e00a89f7e98908534985ab1711
Latest deploy log https://app.netlify.com/sites/volto/deploys/65fdd48410a5530008dfc976
ichim-david commented 1 month ago

@ericof I think it is more technically correct to mention that you've added html id tags to the comment container and comments. Anchor link would mean literally a href="#comment" while you simply added the id making them useful if you want that section to come in view in case you add the id to the content url