search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
427 stars 575 forks source link

Incorrect assumption about value of cells in slate table #5947

Open tiberiuichim opened 3 weeks ago

tiberiuichim commented 3 weeks ago

https://github.com/plone/volto/blob/0630a6e7655637c0b811139a738353f682053b79/packages/volto-slate/src/blocks/Table/TableBlockView.jsx#L45

If I have an image (volto-slate can render images inside tables), then it won't be rendered because the string content of that image is nil.

davisagli commented 3 weeks ago

What was that code trying to do?

tiberiuichim commented 3 weeks ago

@davisagli I think it was trying to avoid rendering empty paragraphs, or something like that.