plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
427 stars 575 forks source link

Displays validation error messages on control panel forms #5950

Open wesleybl opened 3 weeks ago

wesleybl commented 3 weeks ago

Fixes: #5274

Now the error is displayed:

download (13)

To works properly, it needs: https://github.com/plone/plone.restapi/pull/1771

But it can be merged separately without any problems.

netlify[bot] commented 3 weeks ago

Deploy Preview for volto canceled.

Name Link
Latest commit 63a7238b7a83bab23d2f028e2412c04b730a1285
Latest deploy log https://app.netlify.com/sites/volto/deploys/663155ebd8ef6100082af817
netlify[bot] commented 3 weeks ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 63a7238b7a83bab23d2f028e2412c04b730a1285
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/663155eb9b050c0008f3b166
wesleybl commented 1 day ago

@ichim-david I ran into the error in the "As editor, I can unlock a locked page" test again. I remember you found a solution to the problem:

https://github.com/plone/volto/pull/5933#issuecomment-2029319339

Do you intend to make this fixe?

wesleybl commented 1 day ago

Could you resolve the merge conflict?

@davisagli done.

ichim-david commented 22 hours ago

@ichim-david I ran into the error in the "As editor, I can unlock a locked page" test again. I remember you found a solution to the problem:

#5933 (comment)

Do you intend to make this fixe?

@wesleybl yup I do ... time to dust up the old pull request I didn't add, April was not a good month for Volto work unlike March :)

ichim-david commented 9 hours ago

@ichim-david I ran into the error in the "As editor, I can unlock a locked page" test again. I remember you found a solution to the problem:

#5933 (comment)

Do you intend to make this fixe?

@wesleybl only left it there for 1 month .. if you would like to test it locally the locking test here is the pull request where I made the changes necessary to avoid errors after running it 20 times in a row as I've given you the comment on how todo it https://github.com/plone/volto/pull/5998