plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
427 stars 575 forks source link

Fix pt_BR translation of invalid email message #5953

Closed wesleybl closed 2 weeks ago

netlify[bot] commented 3 weeks ago

Deploy Preview for volto canceled.

Name Link
Latest commit 131b63e0f58fa17899f5acfced0821490ac72762
Latest deploy log https://app.netlify.com/sites/volto/deploys/661559b4f1125b0008d2d61b
netlify[bot] commented 3 weeks ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 131b63e0f58fa17899f5acfced0821490ac72762
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/661559b4cc51240008f0c1ba
wesleybl commented 3 weeks ago

I'm wondering if the "email" key shouldn't be changed to something with "invalid email".

stevepiercy commented 3 weeks ago

I also would use "Email" instead of the hyphenated and archaic "e-mail". This comment from SO from 2010 is interesting: https://english.stackexchange.com/a/1928

wesleybl commented 3 weeks ago

@stevepiercy In Brazil, the use of the hyphen is still more common. So I think it's better to leave it like that. In English it is already without a hyphen.

davisagli commented 2 weeks ago

I'm wondering if the "email" key shouldn't be changed to something with "invalid email".

That would make sense to me -- but then we should update all the existing translations.

I'll merge this as is, and that can be done in a separate PR.