plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
448 stars 610 forks source link

enable overriding favicon from Helmet component #6013

Open giuliaghisini opened 4 months ago

giuliaghisini commented 4 months ago

if i want to load favicon differently than loading it from /public folder, i have to override the /helpers/Html.js component because favicon is statically linked here and i'm not able to override it by Helmet component.

stevepiercy commented 4 months ago

Is this a duplicate of either?

giuliaghisini commented 4 months ago

Is this a duplicate of either?

no.. here we need to set favicon from an api response, not from a static folder. Otherwise, i thin for all this 3 issues the solution is the same.. maybe the solutions are two:

  1. move the markup of favicon inside a specific component that will be overridable
  2. make Helmet component able to set/render the favicon markup