search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
456 stars 613 forks source link

(Fix) Code complexity high, readability low #6158

Closed iamAyushChamoli closed 2 months ago

iamAyushChamoli commented 3 months ago

Fixes #6078

Type Of Change

Increasing the readability and reducing the complexity by separating the logic into smaller, more manageable functions: handleRequest, handleResponse, and handleError. This makes the code easier to understand and maintain.

mister-roboto commented 3 months ago

@iamAyushChamoli you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

netlify[bot] commented 3 months ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 26d8c5e9b261d5e891ab320ef3c83c736a5584b5
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/668cc4287d8d4700088e839c
stevepiercy commented 3 months ago

@iamAyushChamoli please read and follow First-time contributors, Contributing to Plone, and Contributing to Volto.

In general, you should first file an issue before submitting a pull request to discuss whether the work is needed or wanted.

iamAyushChamoli commented 3 months ago

@stevepiercy apologies for missing it. I'll certainly check it out now. Cheers!

davisagli commented 2 months ago

Closing due to lack of response