search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
446 stars 606 forks source link

Remove `react-share` library and `SocialSharing` component #6162

Closed sneridagh closed 1 month ago

sneridagh commented 1 month ago

The builds start to break because of react-share today, dependencies problem because we are using an ancient version. Let's remove it, since core is not using it anymore.

📚 Documentation preview 📚: https://volto--6162.org.readthedocs.build/

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 5fc7aa37c308ef754b162373f17fa4585008c063
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/668eb7059e395e0008958bd8
sneridagh commented 1 month ago

@stevepiercy Merging, since this is breking builds right now.

pnicolli commented 1 month ago

@sneridagh I just created a new project with cookieplone because I wanted to finally try it and maybe jump on board and bumped into this. Maybe releasing a new alpha would help people that create new projects like I did. I can easily change mrs-developer for now so no rush, but I think it's needed.

sneridagh commented 1 month ago

@pnicolli Today I knew that I overlooked that we would need a release for this, and I missed to do so. I will release Volto asap, I'll try this evening.