Open giuliaghisini opened 1 month ago
Name | Link |
---|---|
Latest commit | c0a3f19204113cdfad8b4b7cc3daa0c58d6112ab |
Latest deploy log | https://app.netlify.com/sites/plone-components/deploys/66c77ce082949c000809d130 |
@mamico @giuliaghisini This doesn't look ready for testing yet due to the unit test failure
The failing CI check for readme-link-check is due to https://www.cmscom.jp not responding. @terapyon would you please look into this?
Otherwise it is all green, but could use one more round of reviews. @giuliaghisini would you please add your review? Thank you!
@mamico you've turned a bugfix into a breaking change. If you modify where the config is at it will need a breaking notice and an upgrade mention. I would wait for this action though to hear what @davisagli thinks about your proposal to move the config setting. EDIT: Was too quick to react, I've added a reply here https://github.com/plone/volto/pull/6173#issuecomment-2294819425
@mamico you've turned a bugfix into a breaking change. If you modify where the config is at it will need a breaking notice and an upgrade mention. I would wait for this action though to hear what @davisagli thinks about your proposal to move the config setting.
@mamico disregard this statement I should of paid more attention that you added something instead of modifying the name and import. There is no documentation about this new option though
For docs, see https://6.docs.plone.org/volto/contributing/documentation.html.
@ichim-david as far as what to document and where, I don't see anything for nonContentRoutes
in Routing (so sad), The configuration registry, or Settings reference guide. Would one of these be appropriate locations?
For docs, see https://6.docs.plone.org/volto/contributing/documentation.html.
@ichim-david as far as what to document and where, I don't see anything for
nonContentRoutes
in Routing (so sad), The configuration registry, or Settings reference guide. Would one of these be appropriate locations?
It would be good to get the setting documented and in the routing docs to link to the routing based settings
For docs, see https://6.docs.plone.org/volto/contributing/documentation.html. @ichim-david as far as what to document and where, I don't see anything for
nonContentRoutes
in Routing (so sad), The configuration registry, or Settings reference guide. Would one of these be appropriate locations?It would be good to get the setting documented and in the routing docs to link to the routing based settings
updated how-to file
if we have nonContentRoutes that aren't cms-ui, for example '/search' now are considered as cmsUi. This adds unnecessary things to the page like:
defining this public routes in config we can avoid this and everithing works well :-D