search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
446 stars 606 forks source link

Refactored PersonalInformation #6177

Closed Prince0906 closed 3 weeks ago

Prince0906 commented 1 month ago

Ref: #4460

About This PR

This PR refactored

packages/volto/src/components/manage/Preferences/PersonalInformation.jsx

from class based to functional component.

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 2669ac59a5d9c97813f631cfac712b1d3c0e0e0f
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/669dc87d05c80600083857a3
ichim-david commented 1 month ago

@Prince0906 before you attempt to port the class based components to functional components you need to look also at the opened pull requests that tackle this task, in particular the ones opened by https://github.com/plone/volto/pulls/Tishasoumya-02 https://github.com/plone/volto/pull/5046

This is because the information from the issue is not fully up to date on what pull requests are opened https://github.com/plone/volto/issues/4460

Doing so will ensure that you don't work for nothing doing duplicated work.

davisagli commented 3 weeks ago

Thanks for your contribution, but I will close this PR because it is a duplicate of #5046 which was already in progress.