plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
456 stars 613 forks source link

Refactor ContentUploadModal.jsx from class based to functional component #6178

Closed antedotee closed 2 months ago

antedotee commented 2 months ago

Ref: #4460

About This PR

This PR refactored

packages/volto/src/components/manage/Contents/ContentsUploadModal.jsx

from class based to functional component.

Before:

https://github.com/user-attachments/assets/eabaddbb-629d-43f0-9107-776840fab8f8

After:

https://github.com/user-attachments/assets/7088d68a-bc22-41bc-97e7-f54e1828411c

mister-roboto commented 2 months ago

@antedotee you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

netlify[bot] commented 2 months ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 03b9d36e6d6002861f5fb24598bdd42b57c8c58d
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/669e529e11f7360008a3ef8c
mister-roboto commented 2 months ago

@antedotee you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

mister-roboto commented 2 months ago

@antedotee you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

antedotee commented 2 months ago

I have signed the contributor agreement still I am getting the error. Any suggestion? CleanShot 2024-07-22 at 18 07 30@2x

stevepiercy commented 2 months ago

@antedotee from https://plone.org/foundation/contributors-agreement

I signed the Agreement, but haven't been given access yet?

Please allow a week for a response. Volunteers process the Contributor Agreements. If you have issues, such as making a spelling error in your email or GitHub username, please contact agreements@plone.org.

You can also add the email you used in the agreement to your GitHub account.

stevepiercy commented 2 months ago

This PR may duplicate work in https://github.com/plone/volto/pull/6178.

Closing because the contributor has not followed up.