search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
456 stars 613 forks source link

Refactor PersonalPreferences #6180

Closed antedotee closed 2 months ago

antedotee commented 2 months ago

Ref: #4460

About This PR

This PR refactored

packages/volto/src/components/manage/Preferences/PersonalPreferences.jsx

from class based to functional component.

Before:

https://github.com/user-attachments/assets/6b68a3f4-6e5e-4c14-a0ed-5fa81e54ee9e

After:

https://github.com/user-attachments/assets/406b38e7-b72e-4e93-883b-ce8a6d44ad90

mister-roboto commented 2 months ago

@antedotee you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

netlify[bot] commented 2 months ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 0d83cd7645fd4be614c361568a8c46f1c91eb515
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/669e57ba2759d500088c02f3
stevepiercy commented 2 months ago

@antedotee it appears you are having difficulty with git, as I see files from another PR are coming through in this PR. We have a guide to help you with git in Write code.

Also see Item 3 in Things not to do.