search

plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
446 stars 606 forks source link

Refactored cell.jsx to functional component #6182

Closed Raman-Luhach closed 2 days ago

Raman-Luhach commented 1 month ago

Refactored cell.jsx from class-based to functional-based component.

This is my first contribution to volto. Please give feedback and I will try to rectify that.

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit f0f0ad6063869fa366e3886c87409ef8b9a454ec
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66a5e9a1965684000886eff1
stevepiercy commented 1 month ago

@Raman-Luhach thank you for your contribution! Here are some things to address.

The change log check fails with this message https://github.com/plone/volto/actions/runs/10047245268/job/27768503949?pr=6182. You need to move the change log entry to the appropriate package, packages/volto-slate, per Change log entry.

Next run acceptance tests locally before creating a pull request according to Acceptance tests. Two GitHub workflows currently fail. That could be a flaky test. When you run tests locally, it is easier to compare against GitHub workflows and debug the issue. If tests pass locally, but fail in GitHub workflows, then post a comment with details and ask for assistance if you need help.

Finally keep your feature branch current with main. See Update your pull request from your fork.

stevepiercy commented 1 month ago

@Raman-Luhach CI checks still fail. Please resolve them.

stevepiercy commented 1 month ago

@sneridagh this is another PR that was not listed in #4460, but that list may have been before the monorepo and splitting out volto-slate. Please advise.

davisagli commented 2 days ago

This is already in progress in #4963