plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
446 stars 606 forks source link

Refactored Edit component from class based to function based #6187

Open shiven16 opened 1 month ago

shiven16 commented 1 month ago

About This PR

This PR refactored:

packages/volto-slate/src/blocks/Table/TableBlockEdit.jsx

from class based to function based component

Please review and provide feedback on my changes. I am committed to addressing any issues promptly.

netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 3197e972e295483457faf84d502f0a1a2580d63c
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66a63a0ee7988700082257a0
stevepiercy commented 1 month ago

@shiven16 please read and follow Change log entry and Linting.

stevepiercy commented 1 month ago

@shiven16 please check Change log entry and Linting again, and now check why the acceptance tests fail by comparing the GitHub workflow result against your local acceptance test run, as described in Acceptance tests. It might also be helpful for you to review the entire Developer guidelines, so that I don't have to keep pointing you to each thing that does not pass CI.

shiven16 commented 1 month ago

@shiven16 please check Change log entry and Linting again, and now check why the acceptance tests fail by comparing the GitHub workflow result against your local acceptance test run, as described in Acceptance tests. It might also be helpful for you to review the entire Developer guidelines, so that I don't have to keep pointing you to each thing that does not pass CI.

I apologize for any inconvenience caused. I will ensure that all tests are run locally prior to committing changes to the repository.

stevepiercy commented 1 month ago

@shiven16 please read and follow Code quality. You should run all of these checks locally to ensure they pass before creating a pull request. Then you can compare your results against the GitHub workflows.

See also Update your pull request from your fork.

stevepiercy commented 1 month ago

@shiven16 what was the result of running tests locally? Why do you think the CI checks fail?

See also Update your pull request from your fork.