plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
487 stars 664 forks source link

Fix clean make command #6403

Closed sneridagh closed 1 month ago

sneridagh commented 1 month ago

Closes https://github.com/plone/volto/pull/6403


netlify[bot] commented 1 month ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 54c8d7988eb3618136a0bce0f5aaa2c293d09b3f
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/670cfb00f42d84000844736c
fredvd commented 1 month ago

copied from PR:

Tested locally with the branch: the files are now kept.

When running make, it still shows warnings that it cannot find node_modules with the find, which is strange and exits with an error code . Running make clean a second time and the clean finishes ok.

Another thing while testing the issue with make clean. When I do a clean checkout from the the plone/volto repo and do a make install, is it normal that the pnpm-lock.yaml be changed right away compared to git? I updated to the latest pnpm . AFAIK KGS is KGS, or can this happen anytime with pnpm that is finds newer minor versions within the ranges specified for packages?

Studio1:volto fred$ make clean
find: ./packages/blocks/node_modules: No such file or directory
find: ./packages/generator-volto/node_modules: No such file or directory
find: ./packages/types/node_modules: No such file or directory
find: ./packages/volto-slate/node_modules: No such file or directory
find: ./packages/coresandbox/node_modules: No such file or directory
find: ./packages/providers/node_modules: No such file or directory
find: ./packages/volto-testing/node_modules: No such file or directory
find: ./packages/volto/node_modules: No such file or directory
find: ./packages/components/node_modules: No such file or directory
find: ./packages/scripts/node_modules: No such file or directory
find: ./packages/registry/node_modules: No such file or directory
find: ./packages/slots/node_modules: No such file or directory
find: ./packages/client/node_modules: No such file or directory
find: ./packages/helpers/node_modules: No such file or directory
make: *** [clean] Error 1
Studio1:volto fred$ make clean

pnpm-lock.yaml changes:

git-diff-output.log

sneridagh commented 1 month ago

@fredvd I haven't tried the command, but I tried the find and it did work, no clue why it's complaining.

Regarding the pnpm changes, sometimes if someone changes the metadata of a package during a minor, etc, the lock changes. However, it's only metadata too.

Remember to install pnpm always using corepack, no local manual installation.