plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
486 stars 661 forks source link

Update browserlist #6455

Closed sneridagh closed 3 weeks ago

sneridagh commented 3 weeks ago

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

netlify[bot] commented 3 weeks ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit 67a586249feebb52c0e906f9a20d860d3808e893
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6723a81e2c135c00088b51c4
stevepiercy commented 3 weeks ago

https://www.npmjs.com/package/browserlist says use https://github.com/browserslist/browserslist. browserslist. Should we use GitHub directly instead of npmjs.com?

Also https://6.docs.plone.org/volto/contributing/language-features.html#browser-compatibility should be updated, if you change that requirement. There's also another typo.

davisagli commented 3 weeks ago

@stevepiercy We are in fact using browserslist, not browserlist. It is misspelled in the title of this PR, the towncrier entry, and a couple places in https://6.docs.plone.org/volto/contributing/language-features.html#browser-compatibility

Updating the package doesn't change the rules that we are using it to apply.

stevepiercy commented 3 weeks ago

Addressed in https://github.com/plone/volto/commit/528ef97cc26998029e6c67c2baa9e7e45eb5238f as part of https://github.com/plone/volto/pull/6397