plone / volto

React-based frontend for the Plone Content Management System
https://demo.plone.org/
MIT License
486 stars 661 forks source link

fixes #6428 #6479

Closed Rishith-S closed 2 weeks ago

Rishith-S commented 2 weeks ago

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6428

This PR solves the issue not being able to search in sub pages

https://github.com/user-attachments/assets/397763d1-b6af-4c7d-940d-02ff0e8e1cf7

mister-roboto commented 2 weeks ago

@Rishith-S you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have already signed the agreement, please allow a week for your agreement to be processed. Once it is processed, you will receive an email invitation to join the plone GitHub organization as a Contributor.

If after a week you have not received an invitation, then please contact agreements@plone.org.

mister-roboto commented 2 weeks ago

Eksaq Dev the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them.

Add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

Change the email address in your commits: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

netlify[bot] commented 2 weeks ago

Deploy Preview for plone-components canceled.

Name Link
Latest commit bc007f7242271b9c6bd17334f8cc7ca62029a24a
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/672da33e4babec0008588792
stevepiercy commented 2 weeks ago

@Rishith-S this is an incorrect implementation. You should first discuss in the original issue the exact problem, and how to best solve it. Closing.

stevepiercy commented 2 weeks ago

Also do not open multiple PRs for a single issue.

Please read and follow Things not to do.

Rishith-S commented 2 weeks ago

@stevepiercy sorry for the mistake from my side