ploomber / core

Core module shared across projects.
https://ploomber-core.readthedocs.io
Apache License 2.0
2 stars 9 forks source link

Local test runs generate telemetry data by default #26

Open yafimvo opened 1 year ago

yafimvo commented 1 year ago

We should consider disabling the telemetry by default when running tests locally.

@idomic @edublancas

idomic commented 1 year ago

We need to add a fixture to each of the repos conftest

edublancas commented 1 year ago

We have it here . We can make it part of this package so only import it in other places.

e.g., importing this into any other package conftest.py:

from ploomber_core._testing import block_posthog

Should define the fixture and block posthog

edublancas commented 1 year ago

I think it's now a good time to revisit the logic. seems like this feature depends on two fixture definitions monkeypatch_session, and external_access. Insure if we need both and also unsure about the scope='class' argument since we're not using class-based test suites.

idomic commented 1 year ago

I think what probably is missing is the import piece, we've been seeing test events into posthog

edublancas commented 1 year ago

this has not been implemented: from ploomber_core._testing import block_posthog

I'm suggesting we implement it so we can import it in this repo's contest and all others.