Update jupyterlab4

[brichet]

Describe your changes

This PR updates the plugins to jupyterlab 4.

It cherry-picked the commits from jupyterlab4 branch, as discussed https://github.com/ploomber/jupysql/issues/930#issuecomment-1868397347.

Issue number

Related to https://github.com/ploomber/jupysql/issues/930

Checklist before requesting a review

• [x] Performed a self-review of my code
• [x] Formatted my code with pkgmt format
• [x] Added tests (when necessary).
• [x] Added docstring documentation and update the changelog (when needed)

[edublancas]

hey @brichet is this ready for review?

[neelasha23]

The autocomplete results look different:

Previously:

As per this PR:

Also, I don't see the SQL Formatting button and highlighting also doesn't seem to be working?

@brichet

[brichet]

Also, I don't see the SQL Formatting button and highlighting also doesn't seem to be working?

Thanks for your feedbacks. Can you check the jupyterlab version please, it worked on my side, but I can't test it again currently.

[brichet]

hey @brichet is this ready for review?

I think so, yes.

[neelasha23]

Can you check the jupyterlab version please

It's 4.0.10

@brichet

[bryannho]

The autocomplete results look different: Also, I don't see the SQL Formatting button and highlighting also doesn't seem to be working?

@neelasha23 @brichet I'm experiencing the same issue, also on jupyterlab 4.0.10

[brichet]

Let's wait for review, the syntax highlighting doesn't work for me neither anymore. However, formating and completion work on my side with lab 4.0.10.

[neelasha23]

Let's wait for review, the syntax highlighting doesn't work for me neither anymore. However, formating and completion work on my side with lab 4.0.10.

Please check in a clean environment. We might be missing something! Also, please address the existing review comments @brichet

[brichet]

@neelasha23 everything works fine on my side, in a new environment. Does it still not work on your side?

@bryannho thanks for the first review, I updated the syntax highlighting implementation and the completer tests.

@edublancas wondering whether we should add jupysql and ipywidget as dependencies.

[edublancas]

I just tested this on a clean environment, and it works (I tested syntax highlighting, autocompletion, and formatting). @neelasha23 if you're having issues testing it, run git clean -fdx to clean all JS/TS modules + any other extra files and then install everything.

@brichet no need to add those dependencies, jupysql-plugin is already a dependency in jupysql, and the idea is that people should get the jupysql-plugin via pip install jupysql

@bryannho please resolve any pending observations so we can merge this soon!

[edublancas]

@brichet thanks so much for working on this! I'll make a release today/tomorrow