search

ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License
15 stars 11 forks source link

remove bootstrap #101

Open edublancas opened 7 months ago

edublancas commented 7 months ago

adding bootstrap is changing the JupyterLab UI, as far as I remember, we're only using it for the connector widget

more details here: https://github.com/ploomber/jupysql/issues/930#issuecomment-1871308403

the connector widget only needs a few UI components, we can get rid of bootstrap and just add the necessary CSS to make it work without extra dependencies.

another option might be to re-use JupyterLab components.

@brichet do you know if JupyterLab exposes any styled components library that we can re-use? (buttons, text fields, etc)

brichet commented 7 months ago

Yes, you can take a look at jupyter-ui-toolkit, which provides a lot of components that can be used in Jupyter ecosystem. Jupyterlab will start using it for toolbars and button in the next minor version (4.1.0).