search

ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Remove share notebook button #106

Closed neelasha23 closed 9 months ago

neelasha23 commented 9 months ago

Describe your changes

Remove the share notebook button

Issue number

Closes #103

Checklist before requesting a review

neelasha23 commented 9 months ago

The ui-tests have started failing and I see the same issue in the ploomber-extension PR as well, so I think it's not related to this change. Still looking into it! @edublancas

edublancas commented 9 months ago

they look related:

        6 |     await page.notebook.openByPath("sample.ipynb");
       7 |     await page.notebook.activate("sample.ipynb");
    >  8 |     await page.getByTestId('share-btn').locator('button').click();
         |                                                           ^
       9 |
      10 |     await expect(page.locator('.jp-Dialog')).toContainText('You need an API key to upload this notebook');
      11 | });

        at /Users/runner/work/jupysql-plugin/jupysql-plugin/ui-tests/tests/share_notebook.test.ts:8:59

    attachment #1: video (video/webm) ──────────────────────────────────────────────────────────────
    test-results/tests-share_notebook-test-prompt-user-for-api-key/video.webm
    ────────────────────────────────────────────────────────────────────────────────────────────────

seems like there are some tests that should be removed/updated