ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Providing extra info when autocompleting #7

Open edublancas opened 1 year ago

edublancas commented 1 year ago

It'd be great to provide more context in the autocompletion suggestions

example: add some text explaining that CREATE TABLE will create a new database, and also include a link to a documentation page with examples (we can add this to jupysql docs)

edublancas commented 1 year ago

this looks useful, already autocompletes table names: https://github.com/CybercentreCanada/jupyterlab-sql-editor

@neelasha23

neelasha23 commented 1 year ago

I'll check

edublancas commented 1 year ago

another example: https://github.com/pbugnion/jupyterlab-sql

bryannho commented 1 year ago

this looks useful, already autocompletes table names: https://github.com/CybercentreCanada/jupyterlab-sql-editor

I found that this extension is more useful because it provides autocomplete - but only for sparksql and trino magics. Would it be more viable to incorporate this extension and try to extend it to include jupysql magic, or to replicate the basic methods it uses for autocomplete directly in our own plugin?

edublancas commented 1 year ago

we need to implement our own, but we can use those extensions as a reference for our implementation

edublancas commented 1 year ago

@bryannho what's the status here?

bryannho commented 1 year ago

@bryannho what's the status here?

Had started on this but paused to work on the CI issue. Will resume but might run into CI issue again

edublancas commented 1 year ago

ok, no worries. I can unassign and assign something else